Conversation
nroj95
force-pushed
the
feature/miyoo-screenshot-hotkey
branch
from
August 11, 2026 18:04
3eb3810 to
ae69964
Compare
nroj95
force-pushed
the
feature/miyoo-screenshot-hotkey
branch
from
August 15, 2026 00:10
ae69964 to
1c44c56
Compare
chrisj951
requested changes
Sep 14, 2026
| Controller.clear_last_input() | ||
| elif Controller.last_controller_input == ControllerInput.MENU: | ||
| if not Controller.is_check_for_hotkey and not called_from_check_for_hotkey and not Controller.check_for_hotkey(): | ||
| if not called_from_check_for_hotkey and os.path.exists("/tmp/screenshot_menu_consumed"): |
Contributor
There was a problem hiding this comment.
There's some other code creating problems that this is just circumventing but not addressing. If you have time the update should be
Add a new key to App/PyUI/py-ui-config.json of ignoreMenuCombinationPresses
In Controller.py if ignoreMenuCombinationPresses is true, then have check_for_hotkey skip the actual performance of the hotkey, but report back that it WAS a hotkey press
This should prevent the rest of the code from seeing the menu, and allow delegating the hotkey solely to outside of PyUIs control instead of it being a weird shared handoff
Contributor
|
If you remove the PyUI side of this I am okay with this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds MENU+SELECT as an additional global screenshot shortcut option.
changes:
tested on Miyoo Mini Plus: