Align PostgreSQL Testcontainers image version across integration tests#5401
Open
seonwooj0810 wants to merge 1 commit into
Open
Align PostgreSQL Testcontainers image version across integration tests#5401seonwooj0810 wants to merge 1 commit into
seonwooj0810 wants to merge 1 commit into
Conversation
Update PostgreSQLJobRepositoryIntegrationTests, PostgresPagingQueryProviderIntegrationTests, and PostgreSQLJpaIntegrationTests to use postgres:18.1, matching the version already used in PostgreSQLMigrationScriptIntegrationTests. This eliminates the drift introduced when only the migration test was updated to postgres:18.1, leaving the other three integration tests on postgres:17.5, so that the whole PostgreSQL integration test suite is validated against the same major version. Resolves spring-projects#5383 Signed-off-by: Seonwoo Jung <laborlawseon@kap.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the PostgreSQL Testcontainers image version across the four PostgreSQL-based integration tests in spring-batch. After this change all four tests use
postgres:18.1.spring-batch-core/.../migration/PostgreSQLMigrationScriptIntegrationTests.javapostgres:18.1postgres:18.1(unchanged)spring-batch-core/.../PostgreSQLJobRepositoryIntegrationTests.javapostgres:17.5postgres:18.1spring-batch-infrastructure/.../PostgresPagingQueryProviderIntegrationTests.javapostgres:17.5postgres:18.1spring-batch-samples/.../PostgreSQLJpaIntegrationTests.javapostgres:17.5postgres:18.1This eliminates the drift described in #5383, where the migration tests and the rest of the suite were validated against different PostgreSQL major versions.
Test plan
postgres:17.5, one referencedpostgres:18.1.postgres:18.1.DockerImageName.parse(...)— no logic change../mvnw verifycould not be executed locally: thespring-batch-infrastructuremain compile fails on JDK 21 with a pre-existingNullAway/ JSpecify error (Running NullAway in JSpecify mode requires either JDK 22+ ...). The project's CI uses Java 25 (.github/workflows/continuous-integration.yml), so this is an environment limitation, not a regression introduced by this change. Verified by reproducing the same error against unmodifiedmain.Verification done
gh pr list --repo spring-projects/spring-batch --search "postgres testcontainers" / "5383" / "postgres:18.1"returned no matching PR;/issues/5383/eventsshows only the originallabeledevent with no cross-reference..javaintegration test files.mainviagh search code: 3 files usepostgres:17.5, 1 usespostgres:18.1(matching the issue body exactly).status: waiting-for-triage.Resolves #5383