Skip to content

refactor(providers): derive provider options from ConfidenceOptions #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicklasl wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor(providers): derive provider options from ConfidenceOptions #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d5fe76
refactor(providers): derive provider options from ConfidenceOptions
nicklasl Jun 15, 2026
ee2937c
chore: update API baselines
nicklasl Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions api/openfeature-server-provider.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Provider, ProviderMetadata, ProviderStatus, EvaluationContext, ResolutionDetails, JsonValue } from '@openfeature/server-sdk';
import { FlagResolver, Confidence } from '@spotify-confidence/sdk';
import { FlagResolver, ConfidenceOptions, Confidence } from '@spotify-confidence/sdk';

/**
* OpenFeature Provider for Confidence Server SDK
Expand Down Expand Up @@ -28,16 +28,7 @@ declare class ConfidenceServerProvider implements Provider {
/**
* Factory Options for Confidence Server Provider
* @public */
type ConfidenceProviderFactoryOptions = {
region?: 'eu' | 'us';
fetchImplementation?: typeof fetch;
clientSecret: string;
timeout: number;
/** Sets an alternative resolve url */
resolveBaseUrl?: string;
/** Sets an alternative apply url */
applyBaseUrl?: string;
};
type ConfidenceProviderFactoryOptions = Omit<ConfidenceOptions, 'environment' | 'library' | 'context'>;
/**
* Creates an OpenFeature-adhering Confidence Provider
* @param options - Options for Confidence Provider
Expand Down
13 changes: 2 additions & 11 deletions api/openfeature-web-provider.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Provider, ProviderMetadata, OpenFeatureEventEmitter, EvaluationContext, ResolutionDetails, JsonValue } from '@openfeature/web-sdk';
import { FlagResolver, Confidence } from '@spotify-confidence/sdk';
import { FlagResolver, Confidence, ConfidenceOptions } from '@spotify-confidence/sdk';

/**
* OpenFeature Provider for Confidence Web SDK
Expand Down Expand Up @@ -35,16 +35,7 @@ declare class ConfidenceWebProvider implements Provider {
/**
* Factory Options for Confidence Web Provider
* @public */
type ConfidenceWebProviderOptions = {
region?: 'eu' | 'us';
fetchImplementation?: typeof fetch;
clientSecret: string;
timeout: number;
/** Sets an alternative resolve url */
resolveBaseUrl?: string;
/** Sets an alternative apply url */
applyBaseUrl?: string;
};
type ConfidenceWebProviderOptions = Omit<ConfidenceOptions, 'environment' | 'library' | 'context'>;
/**
* Creates an OpenFeature-adhering Confidence Provider
* @param options - Options for Confidence Provider
Expand Down
13 changes: 2 additions & 11 deletions packages/openfeature-server-provider/src/factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
import { Provider } from '@openfeature/server-sdk';
import { ConfidenceServerProvider } from './ConfidenceServerProvider';
import { Confidence } from '@spotify-confidence/sdk';
import { Confidence, ConfidenceOptions } from '@spotify-confidence/sdk';

/**
* Factory Options for Confidence Server Provider
* @public */
export type ConfidenceProviderFactoryOptions = {
region?: 'eu' | 'us';
fetchImplementation?: typeof fetch;
clientSecret: string;
timeout: number;
/** Sets an alternative resolve url */
resolveBaseUrl?: string;
/** Sets an alternative apply url */
applyBaseUrl?: string;
};
export type ConfidenceProviderFactoryOptions = Omit<ConfidenceOptions, 'environment' | 'library' | 'context'>;

/**
* Creates an OpenFeature-adhering Confidence Provider
Expand Down
13 changes: 2 additions & 11 deletions packages/openfeature-web-provider/src/factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
import { Provider } from '@openfeature/web-sdk';
import { ConfidenceWebProvider } from './ConfidenceWebProvider';
import { Confidence } from '@spotify-confidence/sdk';
import { Confidence, ConfidenceOptions } from '@spotify-confidence/sdk';

/**
* Factory Options for Confidence Web Provider
* @public */
export type ConfidenceWebProviderOptions = {
region?: 'eu' | 'us';
fetchImplementation?: typeof fetch;
clientSecret: string;
timeout: number;
/** Sets an alternative resolve url */
resolveBaseUrl?: string;
/** Sets an alternative apply url */
applyBaseUrl?: string;
};
export type ConfidenceWebProviderOptions = Omit<ConfidenceOptions, 'environment' | 'library' | 'context'>;

/**
* Creates an OpenFeature-adhering Confidence Provider
Expand Down
Loading