Tse26#217
Open
barbosamaatheus wants to merge 8 commits into
Open
Conversation
Adding partial results
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Soot output-processor runner to (a) let users choose the call graph algorithm via -cg/--callgraph and (b) optionally keep partial results when an analysis times out via -prt/--partial-results-on-timeout.
Changes:
- Added CLI flags for call graph selection (
-cg) and partial-results-on-timeout (-prt), plus documentation updates. - Plumbed call graph option into Soot config generation and refactored algorithm constructors to accept it.
- Introduced timeout-handling changes in
ConflictDetectionAlgorithmto optionally return partial results.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/services/outputProcessors/soot/RunSootAnalysisOutputProcessor.groovy | Adds propagation hook for partial-results-on-timeout across configured algorithms. |
| src/main/services/outputProcessors/soot/README.md | Documents new -cg and -prt flags. |
| src/main/services/outputProcessors/soot/NonCommutativeConflictDetectionAlgorithm.groovy | Consolidates constructors and adds call graph option to generated Soot configs. |
| src/main/services/outputProcessors/soot/Main.groovy | Wires partial-results-on-timeout flag and starts passing call graph into some algorithm constructions. |
| src/main/services/outputProcessors/soot/ConflictDetectionAlgorithm.groovy | Adds call graph option, partial-results-on-timeout behavior, and new timeout/output-thread handling. |
| src/main/services/outputProcessors/soot/arguments/Arguments.groovy | Adds fields/getters/setters for call graph + partial-results-on-timeout. |
| src/main/services/outputProcessors/soot/arguments/ArgsParser.groovy | Adds parsing/validation for -cg and -prt. |
| README.md | Normalizes Gradle build command to ./gradlew. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| processOutputThread.join(GRACE_PERIOD_MILLIS) | ||
| String partial = atomicResult.get() | ||
| println "Result at timeout: ${partial}" | ||
| return partial + "-timeout" |
Comment on lines
+152
to
+155
| } else { | ||
| processOutputThread.interrupt(); | ||
| } | ||
| return "timeout"; |
| if (this.options.cg) { | ||
| String algorithm = options.cg?.toString()?.trim()?.toUpperCase() | ||
| if (!algorithm || !["CHA", "RTA", "VTA", "SPARK"].contains(algorithm)) { | ||
| throw new IllegalArgumentException("Invalid callgraph algorithm: ${options.cg}") |
| List<ConflictDetectionAlgorithm> detectionAlgorithms = new ArrayList<ConflictDetectionAlgorithm>(); | ||
|
|
||
|
|
||
| String callgraph = appArguments.getCallgraph(); |
pauloborba
requested changes
Jun 28, 2026
| if (this.options.r) { | ||
| args.setReachability(true) | ||
| } | ||
| if (this.options.cg) { |
Member
There was a problem hiding this comment.
@barbosamaatheus se o usuário não usar a opção cg, qual o algoritmo padrão usado? deveria ser o mesmo usado antes, para mantermos compatibilidade com experimentos anteriores; não termos que alterar experimentos anteriores para adicionar essa opção
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.