Fix build-lod SH degree clamping logic#359
Open
asundqui wants to merge 1 commit into
Open
Conversation
…logic. Update build-lod to include clamping and final max_sh in RAD comments.
mrxz
approved these changes
Jun 2, 2026
Collaborator
|
LGTM, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed confusing
set_max_sh_degreeto betterclamp_sh_degreeand fix logic. Added the clamping vs. final max_sh_degree to the RAD file annotations.This fixes #352 . Tested for both Gsplat and Csplat on SOG files with fewer degrees than the max-sh cmdline setting.