refactor: switch db_events to concrete native_api::Api instance - #211
Merged
Conversation
1.70.0Bug Fixes
Features
|
JayWhite2357
force-pushed
the
feat/db-events-concrete-api
branch
from
July 30, 2026 23:44
5a3d791 to
6d75f09
Compare
JayWhite2357
force-pushed
the
feat/db-events-concrete-api
branch
from
July 31, 2026 00:06
6d75f09 to
40c9a27
Compare
JayWhite2357
changed the title
db_events to concrete native_api::Api instance
JayWhite2357
changed the title
db_events to concrete native_api::Api instancedb_events to concrete native_api::Api instance
JayWhite2357
force-pushed
the
feat/db-events-concrete-api
branch
from
August 3, 2026 06:33
40c9a27 to
9a7602c
Compare
tlovell-sxt
approved these changes
Aug 3, 2026
tlovell-sxt
left a comment
tlovell-sxt
left a comment
Contributor
There was a problem hiding this comment.
Yeah, the fact that this is passing CI makes me wonder what motivated the original design, perplexing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to simplify the code, we can use the
native_api::Apiin thedb_eventsmodule directly. This is the concrete implementation that is used in the actual runtime, and it can also be used in tests. A generic type is not needed for mocking.Are these changes tested?
Existing test cover this change.