Fix Infinite Sleeper Agents + Tests - #46065
Open
Princess-Cheeseballs wants to merge 7 commits into
Open
Princess-Cheeseballs wants to merge 7 commits into
Princess-Cheeseballs wants to merge 7 commits into
Conversation
Member
Author
Member
Author
Velken
approved these changes
Sep 19, 2026
Velken
left a comment
Member
There was a problem hiding this comment.
looks good to me, and no more infinite sleeper agents within 5 minutes, at least on my testings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





…but no game
About the PR
Title. Fixed the infinite sleeper agents bug.
This was as simple as properly checking ProtoId against ProtoId instead of against the name :P.
However I decided to actually go back and add tests because I forgot to before, and got a little soaped.
Why / Balance
Buge. Code cleanup yum!
Technical details
Fix a bug and then optimize some code. Add a test.
Test plan
Run the tests.
Bottom text.
Media
Requirements
Breaking changes
CanRunno longer skips checks if the round has just started.TryBuildLimitedEventsandAvailableEventsnow return anEventTableinstead of a Dictionary.FindEventnow takes anEventTableinstead of a DictionaryChangelog