Skip to content

Upgrade Sourcemeta dependencies - #923

Merged
jviotti merged 2 commits into
mainfrom
new-no-binpack
Oct 24, 2026
Merged

jviotti merged 2 commits into
mainfrom
new-no-binpack

Conversation

@jviotti

@jviotti jviotti commented Oct 24, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 68 files

View guided diff | Re-trigger cubic

@augmentcode

augmentcode Bot commented Oct 24, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Upgrades Sourcemeta dependencies and consolidates JSON BinPack integration into Blaze.

  • Updates Core to 7e3e5ee and Blaze to 2c5efbd.
  • Keeps Blaze's Core dependency pin aligned.
  • Removes the standalone JSONBinPack dependency and vendored implementation.
  • Removes its CMake discovery module and package lookup.
  • Links the CLI against sourcemeta::blaze::binpack.
  • Migrates encode/decode compilation, loading, and runtime APIs to Blaze.
  • Changes JSON Pointer fragment parsing to decode individual tokens and reject encoded slashes.
  • Adds canonical-URI fallback to typed schema-frame location lookups.
Technical notes: Shares URI-spelling fallback with traversal and updates related API documentation.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

}

const auto decoded{sourcemeta::core::URI::unescape(token)};
if (decoded.find('/') != std::string::npos) {

@augmentcode augmentcode Bot Oct 24, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we revisit this rejection in vendor/core/src/core/jsonpointer/jsonpointer.cc:41–42? Under RFC 6901 §6's URI-fragment representation, #/$defs%2FX decodes to /$defs/X, but fragment_to_pointer now returns nullopt, making $refs to an existing $defs.X fail resolution (the leading-slash check similarly rejects #%2F$defs%2FX).

Other locations where this applies: vendor/core/src/core/jsonpointer/jsonpointer.cc:379

Severity: medium

Other Locations
  • vendor/core/src/core/jsonpointer/jsonpointer.cc:379

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit 1de0c7c into main Oct 24, 2026
16 checks passed
@jviotti
jviotti deleted the new-no-binpack branch October 24, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant