Repository navigation
Upgrade Sourcemeta dependencies - #923
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Upgrades Sourcemeta dependencies and consolidates JSON BinPack integration into Blaze.
🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| const auto decoded{sourcemeta::core::URI::unescape(token)}; | ||
| if (decoded.find('/') != std::string::npos) { |
There was a problem hiding this comment.
Could we revisit this rejection in vendor/core/src/core/jsonpointer/jsonpointer.cc:41–42? Under RFC 6901 §6's URI-fragment representation, #/$defs%2FX decodes to /$defs/X, but fragment_to_pointer now returns nullopt, making $refs to an existing $defs.X fail resolution (the leading-slash check similarly rejects #%2F$defs%2FX).
Other locations where this applies: vendor/core/src/core/jsonpointer/jsonpointer.cc:379
Severity: medium
Other Locations
vendor/core/src/core/jsonpointer/jsonpointer.cc:379
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com