fix(routes): require authentication on upload, process, and generate-sheet endpoints - #1732
Open
singhanurag0317-bit wants to merge 1 commit into
Open
fix(routes): require authentication on upload, process, and generate-sheet endpoints#1732singhanurag0317-bit wants to merge 1 commit into
singhanurag0317-bit wants to merge 1 commit into
Conversation
|
@singhanurag0317-bit is attempting to deploy a commit to the souma9830's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Require authentication on upload, process, and print routes
Closes #891
Problem
Three critical routes lacked
authMiddleware, letting anyone upload files, trigger AI processing, or generate print sheets without being logged in:POST /api/upload(and/api/upload/batch)POST /api/processPOST /api/print/generate-sheetChange
Added
authMiddlewareto the handler chains:backend/src/routes/upload.routes.js—/and/batchbackend/src/routes/image.routes.js—/and/processbackend/src/routes/print.routes.js—/generate-sheetThe public
GET /api/print/presetsstays unauthenticated./api/upload/batchis protected as well since it is the same unauthenticated file-upload vector.Tests
New
backend/src/__tests__/routeAuth.test.js(supertest integration):401with"No authentication token provided"when no token is sent.GET /api/print/presetsremains accessible without a token.Full backend suite: 9 suites / 26 tests passing.