fix(face-validator): reject images exceeding 8000x8000 resolution - #1730
Open
singhanurag0317-bit wants to merge 1 commit into
Open
fix(face-validator): reject images exceeding 8000x8000 resolution#1730singhanurag0317-bit wants to merge 1 commit into
singhanurag0317-bit wants to merge 1 commit into
Conversation
|
@singhanurag0317-bit is attempting to deploy a commit to the souma9830's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Missing image resolution boundary check in face quality check
Closes #811
Problem
The
assess_face_qualityendpoint loads user-provided images directly into OpenCV viacv2.imreadwithout validating their resolution. An extremely large upload (pixel-bomb) could exhaust memory and crash the process.Change
check_image_resolution()inpython-ai-service/app/services/face_validator.pythat reads dimensions cheaply via PIL header metadata (Image.open(path).size) — no full pixel decode.validate_image_bytes()now rejects any image whose width or height exceedsMAX_DIMENSION = 8000before the OpenCV decode step.python-ai-service/app/services/test_face_validator_resolution.pycovering normal-size accept plus over-limit rejection (width, height, and both).Tests
test_accepts_normal_size_image,test_rejects_image_with_both_dimensions_over_limit,test_rejects_image_wider_than_limit,test_rejects_image_taller_than_limit.Verification
pyteston the python-ai-service.