fix(face-validator): verify RIFF and WEBP headers for webp magic bytes - #1729
Open
singhanurag0317-bit wants to merge 5 commits into
Open
fix(face-validator): verify RIFF and WEBP headers for webp magic bytes#1729singhanurag0317-bit wants to merge 5 commits into
singhanurag0317-bit wants to merge 5 commits into
Conversation
|
@singhanurag0317-bit is attempting to deploy a commit to the souma9830's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: Insecure WebP magic bytes matching in
face_validatorFixes #809
Problem
detect_image_typeinpython-ai-service/app/services/face_validator.pyvalidated WebP images using only theRIFFmagic (first 4 bytes). Any file starting withRIFF— e.g. WAV audio or AVI video — was misidentified as a WebP image.Change
face_validator.py: WebP detection now requires both theRIFFsignature (bytes 0–3) and theWEBPformat header (bytes 8–11).RIFFwas removed from the generic magic-bytes dict and checked explicitly, so WAV/AVI/other RIFF containers are no longer accepted as images.Tests
python-ai-service/app/services/test_face_validator.py(6 pytest tests): JPEG/PNG detection, validRIFF+WEBPdetection, and rejection of WAV, AVI, and unknown headers.Verification
python-ai-service/app/services/test_face_validator.py). Python is not available in this local environment, so the tests are unverified locally but follow the repo's existing pytest conventions.