fix(upload): register validateImageBuffer magic-byte check on upload route - #1728
Open
singhanurag0317-bit wants to merge 4 commits into
Open
fix(upload): register validateImageBuffer magic-byte check on upload route#1728singhanurag0317-bit wants to merge 4 commits into
singhanurag0317-bit wants to merge 4 commits into
Conversation
|
@singhanurag0317-bit is attempting to deploy a commit to the souma9830's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix:
validateImageBuffermiddleware was defined but never registered on the upload routeFixes #815
Problem
validateImageBufferinupload.middleware.jsverifies file magic bytes, but it was never registered inupload.routes.js. Attackers could upload non-image payloads simply by renaming the extension to.png.Change
backend/src/routes/upload.routes.js: registeredvalidateImageBufferin the single-photo upload pipeline —uploadSinglePhotoOrFile → validateImageBuffer → validateImageChain → uploadPhoto. Non-image payloads are now rejected with HTTP 400 (and the temp file is removed) before any further processing.Tests
backend/src/__tests__/uploadValidation.test.js(2 integration tests via supertest):evil.png(magic-byte mismatch → 400),Verification
npm testinbackend/— 11 suites, 32 tests, all passing.