Skip to content

fix: resolve 4 bugs in SnapPass-AI - #1705

Closed
saurabhhhcodes wants to merge 1 commit into
souma9830:masterfrom
saurabhhhcodes:fix/SnapPass-AI-90580
Closed

fix: resolve 4 bugs in SnapPass-AI#1705
saurabhhhcodes wants to merge 1 commit into
souma9830:masterfrom
saurabhhhcodes:fix/SnapPass-AI-90580

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Description

This PR fixes real bugs found in the codebase:

  • Removed redundant boolean comparison: x === true is equivalent to x (and x === false to !x), and shorter to read.
  • Replaced global isNaN with Number.isNaN: the global version coerces its argument, so isNaN('1') returns false while Number.isNaN is strict.
  • Filled empty catch block: silently swallowing the error hides failures; now logs for debugging.
  • Added rejection handler to Promise.all: an unhandled rejection in any input promise previously crashed silently.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #1704

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the souma9830's projects Team on Vercel.

A member of the Team first needs to authorize it.

@saurabhhhcodes saurabhhhcodes closed this by deleting the head repository Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant