fix(cache): only cache 2xx success responses in cache middleware - #1701
Open
singhanurag0317-bit wants to merge 2 commits into
Open
fix(cache): only cache 2xx success responses in cache middleware#1701singhanurag0317-bit wants to merge 2 commits into
singhanurag0317-bit wants to merge 2 commits into
Conversation
|
@singhanurag0317-bit is attempting to deploy a commit to the souma9830's projects Team on Vercel. A member of the Team first needs to authorize it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: Caching middleware incorrectly caches error response JSONs
Fixes #810
Problem
cacheMiddlewareinbackend/src/middleware/cache.middleware.jsinterceptedres.jsonand cached every response unconditionally. When a database timeout or validation failure occurred, the error response was cached and later served to subsequent valid requests.Change
backend/src/middleware/cache.middleware.js: theres.jsonoverride now caches only whenres.statusCodeis in the success range (200–299). Error responses (4xx/5xx) pass through to the client without being cached.Tests
backend/src/middleware/__tests__/cacheMiddleware.test.js(4 tests):Verification
npm testinbackend/— 9 suites, 24 tests, all passing.