fix(comparator): ensure readable text contrast on passport requirement comparator page - #1690
Open
singhanurag0317-bit wants to merge 1 commit into
Open
fix(comparator): ensure readable text contrast on passport requirement comparator page#1690singhanurag0317-bit wants to merge 1 commit into
singhanurag0317-bit wants to merge 1 commit into
Conversation
…t comparator page
|
@singhanurag0317-bit is attempting to deploy a commit to the souma9830's projects Team on Vercel. A member of the Team first needs to authorize it. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix: Text color same as background — content invisible on "Passport Requirement Comparator" page
Fixes #1220
Problem
On the Passport Requirement Comparator page, text (title, description, checkbox labels, table headers/rows) could blend into the background and become unreadable. Additionally, the page imported
SEOMetadatafrom a non-existent path (../components/SEOMetadata), which broke the/compare-requirementsroute chunk entirely.Root Cause
background: var(--card-bg)with inherited text color, so text picked up the page/theme background color instead of a proper foreground color.PassportComparatorPage.jsximportedSEOMetadatafrom the wrong path — the component lives atcomponents/layout/SEOMetadata(as used byNotFoundPage).Changes
PassportComparatorPage.jsx: fixed the brokenSEOMetadataimport path so the page loads.PassportRequirementComparator.css: explicit high-contrast text colors in both themes —#f8fafc/#cbd5e1against the dark card (≥4.5:1WCAG contrast).PassportComparatorPage.test.jsx(7 tests): verifies the page renders (title, description, checkbox labels, comparison table headers) in light and dark mode, and statically asserts explicit non-inheritforeground colors plus dark-mode contrast overrides exist in the CSS.Verification
npx vitest run— 22 files, 92 tests: only the 4 pre-existing unrelated failures remain (AttireSelectorStudio,SnapPassAssistant,printSheetGenerator,useOfflineSync).