Show connected server name in the UI sidebar#863
Open
hmichopoulos wants to merge 1 commit into
Open
Conversation
When connected, the sidebar only shows the current database name. With several servers (DEV, QA, STAGE, ...) hosting databases of the same name, there is no way to tell which server the current session is on. Add a server label under the database name in the sidebar: - the bookmark name when the connection was opened from a bookmark (usually far more meaningful than a long generated hostname), or - the host:port from the connection string otherwise. The label is exposed as a new "server" field by the connect, switch database and connection-info endpoints, and is preserved across database switches on the same connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When connected, the sidebar only shows the current database name. If you work with several servers (DEV, QA, STAGE, …) that host databases with the same name, there's no way to tell which server the current session is on.
This adds a small server label under the database name in the sidebar:
host:portfrom the connection string otherwise.The label is exposed as a new
serverfield by the connect, switch-database and connection-info endpoints, and is preserved across database switches on the same connection.Closes #862
Testing
go build ./...go test ./pkg/client/ -run 'TestServerHost|TestServerName'Notes
Frontend assets are embedded directly from
static/viago:embed(static/data.go), so no separate asset rebuild is required.