Skip to content

docs: pin API timeout invariants - #187

Merged
believetimothy merged 3 commits into
soroworks:mainfrom
rajiabdulrahmon2020-ui:fix/issue-34
Oct 25, 2026
Merged

believetimothy merged 3 commits into
soroworks:mainfrom
rajiabdulrahmon2020-ui:fix/issue-34

Conversation

@rajiabdulrahmon2020-ui

Copy link
Copy Markdown
Contributor

Summary

  • Add issue-specific guidance for Soroforge operators and maintainers.
  • Preserve existing runtime behavior and compatibility.

Closes #34

Validation

  • git diff --check

@believetimothy believetimothy added the do-not-merge A maintainer has stopped this PR from being merged automatically label Oct 23, 2026
@rajiabdulrahmon2020-ui

Copy link
Copy Markdown
Contributor Author

Updated this PR so it does what #34 asks:

  • Added internal/api/server_timeouts_test.go (package api). It checks that every http.Server timeout set by NewServer is non-zero (ReadHeaderTimeout, ReadTimeout, WriteTimeout, IdleTimeout), that WriteTimeout is longer than requestTimeout, and that the server uses the addr and handler it was given.
  • Removed docs/API_TIMEOUT_INVARIANTS.md, because the issue limits the change to this one test file.
  • Merged current main into the branch, which was 52 commits behind. That is why the test (ubuntu-latest) job was failing.

Checks run locally: gofmt -l is clean, go vet ./... is clean, and go test -count=1 ./... passes, including the three new TestNewServer* tests.

Closes #34

@believetimothy believetimothy removed the do-not-merge A maintainer has stopped this PR from being merged automatically label Oct 25, 2026
@believetimothy
believetimothy merged commit f7fc8ab into soroworks:main Oct 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(api): pin the HTTP server's timeout invariants

2 participants