Repository navigation
fix(api): harden admin rate limit, newsletter subscribe, market resolve - #1831
Merged
hman38705 merged 1 commit intoOct 20, 2026
Conversation
Closes solutions-plug#1725 Closes solutions-plug#1726 Closes solutions-plug#1727 Closes solutions-plug#1732 - admin limiter honours TRUST_PROXY and trusted CIDRs - per-email confirmation cooldown (1/hour) via Redis - disposable-email check matches subdomains, extendable via DISPOSABLE_EMAIL_DOMAINS, and returns the uniform 202 - resolve_market validates outcome_index (i32::try_from) and checks the on-chain resolved outcome
|
@knytcomics-ui Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1725
Closes #1726
Closes #1727
Closes #1732
extract_client_ip_cidrswith configured proxy settings (limit already configurable).DISPOSABLE_EMAIL_DOMAINS.i32::try_frominstead of cast; outcome checked against on-chain resolved outcome.Validation: Rust toolchain unavailable in this environment, so
cargo fmt/clippy/checkwere not run; CI should confirm.