Skip to content

fix: frontend lint CI, ECS APP_ENV/secrets, RDS host (#1769 #1770 #1771 #1772) - #1829

Merged
hman38705 merged 2 commits into
solutions-plug:mainfrom
aishatumba5-svg:fix/1769-1770-1771-1772
Oct 20, 2026
Merged

hman38705 merged 2 commits into
solutions-plug:mainfrom
aishatumba5-svg:fix/1769-1770-1771-1772

Conversation

@aishatumba5-svg

Copy link
Copy Markdown

Closes #1769
Closes #1770
Closes #1771
Closes #1772

  • CI: frontend-lint-typecheck (eslint, tsc --noEmit, prettier) + infra-config-guards, both required by all-tests-passed
  • ECS: set APP_ENV/RUST_ENV; API fails startup on unknown APP_ENV (unit test); inject missing env vars/secrets; API_SIGNING_KEY -> REQUEST_SIGNING_SECRET
  • RDS: DB_HOST uses address (no port)
  • Docs updated (secrets.md, deployment.md)

New GitHub secrets needed per env: API_KEYS, UNSUBSCRIBE_SIGNING_SECRET, SENDGRID_WEBHOOK_SECRET, EMAIL_IDEMPOTENCY_SECRET, BASE_URL, CORS_ALLOWED_ORIGINS, FROM_EMAIL, BLOCKCHAIN_RPC_URL, PREDICTIQ_CONTRACT_ID, APP_ENV.

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@aishatumba5-svg Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

…gent)

- infrastructure/terraform/modules/ecs/main.tf: merged [markers] — model resolved the conflict markers
- infrastructure/terraform/variables.tf: merged [markers] — model resolved the conflict markers

Co-authored-by: Simple Agent <agent@simple.dev>
@hman38705
hman38705 merged commit be11b87 into solutions-plug:main Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants