Skip to content

Fix OTLP collector wiring, workflow permissions, Node 20 and tool caching (#1785-#1788) - #1809

Merged
hman38705 merged 4 commits into
solutions-plug:mainfrom
jhaydeeee-web:fix/jhaydeeee-issues-1785-1788
Oct 19, 2026
Merged

hman38705 merged 4 commits into
solutions-plug:mainfrom
jhaydeeee-web:fix/jhaydeeee-issues-1785-1788

Conversation

@jhaydeeee-web

Copy link
Copy Markdown
Contributor

Closes #1785
Closes #1786
Closes #1787
Closes #1788

Summary

9e86168: infra: add OTLP endpoint variable and collector egress rules (#1785)

Adds infrastructure/terraform/otel_collector.tf with otlp_endpoint, otlp_collector_cidr_blocks and otlp_collector_sg_id variables, plus conditional ECS task egress rules for TCP 4317 and 4318. The ECS module now injects OTLP_ENDPOINT into the API container when an endpoint is set, and docs/DISTRIBUTED_TRACING.md documents the setup.

8c200bb: ci: add least-privilege top-level permissions to six workflows (#1786)

Adds a top-level permissions: contents: read block to accessibility, dependency-scan, docker, license-check, openapi-validation and protect-changelog. In dependency-scan, the Trivy job gets security-events: write and the report job gets issues and pull-requests: write so SARIF upload and PR comments keep working.

240f8f6: ci: bump Node 18 to 20 in workflows and frontend engines (#1787)

Moves every node-version: 18 in test, openapi-validation, dependency-scan and license-check, and the accessibility NODE_VERSION, to Node 20. Raises frontend/package.json engines to >=20.0.0, in line with the TTS Dockerfile.

e26dd97: ci: cache prebuilt cargo tool binaries instead of recompiling (#1788)

Adds actions/cache steps for ~/.cargo/bin binaries of soroban-cli, cargo-llvm-cov, cargo-audit, cargo-nextest and cargo-deny in test, contract-deployment, dependency-scan and license-check. Each install now runs only when the binary is missing (command -v <bin> || cargo install ...), so cache hits skip compilation.

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@jhaydeeee-web Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@hman38705
hman38705 merged commit 74b5b97 into solutions-plug:main Oct 19, 2026
18 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants