Repository navigation
fix: apply the dep scanner JSX setting to every environment - #400
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c3a47d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Co-authored-by: Cursor <cursoragent@cursor.com>
ryansolid
force-pushed
the
fix/issue-387-scan-jsx-all-environments
branch
from
October 8, 2026 20:16
50cad03 to
c3a47d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #387.
Problem
The plugin sets the dep scanner's
optimizeDeps.rolldownOptions.transform.jsx(classic runtime, #262) in its top-levelconfighook. Vite 8 only seeds theclientenvironment from top-leveloptimizeDeps, so other environments scan.tsxwith Rolldown's default React automatic runtime. Server environments default tonoDiscovery: true, but hosts that run SSR outside Node turn discovery back on (@cloudflare/vite-plugin). In those setups the ssr scan fails onreact/jsx-dev-runtimeand pre-bundling is skipped.Fix
configEnvironmentnow gives every non-client environment the same scanner settings:transform.jsx ??= { runtime: 'classic' }, so an app's own per-environment value still wins;.tsrxextension;Client-only entries (
include/exclude) stay top-level.Tests
New
examples/ssr/test/scan.mjs, wired into the example'stestscript:.tsrx, and the scan plugin, and an app-set per-environmentjsxis left alone.entries: ['src/entry-server.tsx'], whose graph has JSX andimport.meta.glob), both the client and ssr scans finish without the failure banner.On
nextwithout the fix, 4/7 checks fail, including the exactreact/jsx-dev-runtime (imported by …/Glob.tsx)banner from the issue. With the fix,examples/ssr(run,boundary,scan) and start-ssrdevpass.Made with Cursor