Skip to content

fix: avoid loading dev toolbar CSS in production - #2338

Closed
sean0407 wants to merge 1 commit into
solidjs:mainfrom
sean0407:codex/fix-production-dev-toolbar-css
Closed

sean0407 wants to merge 1 commit into
solidjs:mainfrom
sean0407:codex/fix-production-dev-toolbar-css

Conversation

@sean0407

Copy link
Copy Markdown

Summary

ErrorBoundary
  when the development overlay is enabled -> clientOnly(import DevToolbar)
  otherwise -> the default error boundary

The static DevToolbar import pulled its stylesheet into production client pages even when the overlay was disabled. This reuses SolidStart's existing lazy clientOnly loader.

Fixes #2327.

Evidence

  • Before: With the fixture app's own CSS import removed, a production build and GET / still linked /_build/assets/entry-client-EBetCt96.css (16,856 bytes; 3.24 kB gzip).
  • After: The same production fixture no longer links an entry-client or dev-toolbar stylesheet. The toolbar CSS is emitted as a separate lazy asset.
  • Production fixture build succeeded, and oxfmt --check passed for the changed source and changeset.

Merge Danger

Door: Two-way

Blast Radius: Low

@changeset-bot

changeset-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5f73ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit f5f73ce
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6acd8c52cd845d06de6de844
😎 Deploy Preview https://deploy-preview-2338--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Oct 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2338

commit: f5f73ce

@sean0407 sean0407 closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: devtools css is included in production

1 participant