refactor: migrate double_literal_format to analysis_server_plugin#281
Conversation
docs: improve code docs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the double_literal_format lint rule and its quick fix to use the new analysis_server_plugin API, migrating from SolidLintRule to MultiAnalysisRule and DartFix to ParsedCorrectionProducer. It also introduces a dedicated visitor (DoubleLiteralFormatVisitor) and comprehensive unit tests. A bug was identified in _correctTrailingZeroLexeme where double literals with an uppercase E exponent (e.g., 1.20E0) are not handled correctly, which can lead to invalid Dart syntax. A robust, non-recursive implementation was suggested to handle both lowercase e and uppercase E exponents.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
test: handle exponentials in test cases
solid-danylosafonov
left a comment
solid-danylosafonov
left a comment
There was a problem hiding this comment.
I think message should be changed, otherwise LGTM
andrew-bekhiet-solid
merged commit e5eef63
into
analysis_server_migration
2 participants
docs: improve code docs
Fixes #274