Migrate avoid_late_keyword rule (default behavior) and tests#231
Open
Islam-Shaaban-Ibrahim wants to merge 25 commits into
Open
Migrate avoid_late_keyword rule (default behavior) and tests#231Islam-Shaaban-Ibrahim wants to merge 25 commits into
Islam-Shaaban-Ibrahim wants to merge 25 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the AvoidLateKeywordRule to the AnalysisRule framework, introducing a dedicated visitor and unit tests. The review highlights a regression where configuration parameters for ignoring types and allowing initializers were removed, and notes a missing import in the visitor class that will cause a compilation error.
Collaborator
|
@Islam-Shaaban-Ibrahim, I believe this rule needs custom params to allow users to configure it. |
andrew-bekhiet-solid
force-pushed
the
migrate/avoid_late_keyword
branch
from
0f69812 to
730d708
Compare
andrew-bekhiet-solid
changed the base branch from
analysis_server_migration
to
implementation-of-parameter-parser
style: improve variable names refactor: use root package path instead of library path refactor: use pattern matching to reduce nesting
refactor: allow mocking resource provider refactor: extract CachedPackageRules model
refactor: use Map<String, Object?> instead of LintOptions as the enabled field is implicitly true for all rules that the analyzer processes remove RuleConfig as it is no longer needed
refactor: use for loop to register rules
andrew-bekhiet-solid
force-pushed
the
implementation-of-parameter-parser
branch
from
d51e1bf to
0975ba7
Compare
fix: add old behavior test: migrate avoid late keyword rule tests
andrew-bekhiet-solid
force-pushed
the
migrate/avoid_late_keyword
branch
from
730d708 to
6092317
Compare
Base automatically changed from
implementation-of-parameter-parser
to
analysis_server_migration
June 10, 2026 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.