Suggestions for tidymodels + vetiver code

[juliasilge]

Hello! 👋 This demo is looking so great; thank you for creating this to show folks how to use our tools. I have a couple of minor suggestions for tidymodels and vetiver code in 01-train-and-deploy-model:

Can you use initial_time_split() here, instead of the manual splitting? Then you can use training() and testing() from tidymodels:

bike_predict/content/02-model/01-train-and-deploy-model/document.qmd

Lines 55 to 58 in 2a18bbb

	n_days_test <- 2
	n_days_to_train <- 10
	train_end_date <- dates[n_days_test + 1]

I don't believe you need to manually save the ptype here (or save versioned = TRUE). This should be grabbed automatically from the model_fit:

bike_predict/content/02-model/01-train-and-deploy-model/document.qmd

Lines 172 to 175 in 2a18bbb

	versioned = TRUE,
	save_ptype = train_data %>%
	head(1) %>%
	select(-n_bikes),

If you'd like a PR for either of these, I would be happy to do it!

[juliasilge]

I edited because I realized that we are predicting on the endpoint here and it doesn't have an augment() method yet, as tracked in rstudio/vetiver-r#10. Apologies!

[SamEdwardes]

Thank you Julia - this is great, I did not know about these functions. I will update the code to include them :)