[srzeszut]

No description provided.

[srzeszut]

@claude review

[github-actions]

Claude finished @srzeszut's task in 50s —— View job

---

🦀 Review

No findings at or above 60% confidence.

<verdict: 0 blocking, 0 should-fix, 0 nit>

[Copilot]

🟡 Changes recommended

The decryption replacement lacks regression coverage verifying that load/1 rejects tampered IVs, authentication tags, and ciphertext, as well as truncated data and invalid headers.

1 open issue

• Add regression tests for authentication and malformed ciphertext failures · New

What changed in this PR

Replaces Cloak-based credential encryption with a native :crypto Ecto type while preserving compatibility with existing encrypted values.

Changes:

• Implements AES-256-GCM encryption and decryption directly in Voyager.Encrypted.Binary.
• Removes Cloak dependencies and the supervised vault, configuring the encryption key directly.
• Adds a compatibility test for ciphertext previously written by Cloak.

File	Description
test/​voyager/​encrypted/​binary_test.exs	Adds a Cloak ciphertext compatibility test.
mix.lock	Removes Cloak dependency locks.
mix.exs	Removes cloak and cloak_ecto dependencies.
lib/​voyager/​vault.ex	Deletes the Cloak vault module.
lib/​voyager/​vault_key.ex	Updates documentation to name the new key consumer.
lib/​voyager/​encrypted/​binary.ex	Implements encryption and decryption using :crypto.
lib/​voyager/​application.ex	Removes the vault from supervision.
config/​test.exs	Configures the test encryption key directly.
config/​runtime.exs	Sets the resolved runtime encryption key directly.
config/​e2e.exs	Configures the end-to-end test encryption key directly.

_{Review effort: Balanced}

[GuzekAlan]

After installing it, deleting valut.key Voyager app doesn't open. Please investigate it