Add Tracer service by hhubert6 · Pull Request #305 · software-mansion/voyager

hhubert6 · 2026-10-15T13:11:51Z

No description provided.

hhubert6 · 2026-10-16T11:42:25Z

@claude review

github-actions · 2026-10-16T11:42:38Z

Claude finished @hhubert6's task in 1m 17s —— View job

🦀 Review

Severity: 🔴 blocking · 🟡 should-fix · 🟢 nit

🔴 75% lib/voyager/services/tracer/config.ex:122 — pids: [nil] makes it through the {:array, :string} cast, then Voyager.Pid.parse/1 raises FunctionClauseError inside changeset/2 instead of returning a field error. Reject values that aren't binaries before parsing.
🟡 75% lib/voyager/services/tracer/config.ex:86 — the agent's name is a hash of voyager_agent.erl only, and the refusal lists now live outside that file. Changing them no longer renames the agent, so nodes that already loaded it keep the old lists. Include agent_macros/0 in the digest, keeping the lists in a module that doesn't depend on Agent.
🟢 90% lib/voyager/services/tracer.ex:6 — the moduledoc says stop/1; the function is stop/0.

<verdict: 1 blocking, 1 should-fix, 1 nit>

hhubert6 · 2026-10-16T13:33:45Z

@claude review

github-actions · 2026-10-16T13:33:57Z

Claude finished @hhubert6's task in 1m 25s —— View job

🦀 Review

No findings: the three earlier points are fixed and nothing new cleared the 60% bar.

…t a remote call

GuzekAlan

Looks solid 🐙

kraleppa

Looks great, please address @GuzekAlan suggestions and we can merge

A batch that reports new drops, here or by the agent, and the run's end append a :dropped entry with the count before the events that follow. Dropped entries are capped with the trace events since a flood sheds a batch at a time.

sessions/0 lists the sessions that can be read and entries/3 returns a page of a session's entries from a seq on, oldest first. truncated? says the page starts at or before an entry evicted from memory, so a reader knows the history it got is incomplete.

start/1 resolves the configured pids on the node in the caller, like configure/3, and passes the node and config it used; the Tracer refuses with :changed if a configure replaced them in between. agent_args is gone, so a session only needs its config to be started again.

…ault active/0 returns just the session. entries/2 takes :since, :before and :limit over [since, before): with :since a page reads forward oldest first, for MCP; without it, the newest entries before :before come newest first, for the UI. truncated? is true only when an evicted entry falls in the range the page covers.

hhubert6 · 2026-10-22T14:08:40Z

@claude review

github-actions · 2026-10-22T14:08:57Z

Claude finished @hhubert6's task in 1m 28s —— View job

🦀 Review

Severity: 🔴 blocking · 🟡 should-fix · 🟢 nit

🟡 70% lib/voyager/pid.ex:28 — Config accepts #PID<0.X.Y> (parse/1 strips the prefix), but resolve/2 only matches a bare "<0.". That string parses as a local pid and fails with {:error, :invalid_pid} instead of being resolved on the node. Strip #PID before matching, or reject the prefix in Config.
🦐 65% lib/voyager/services/tracer/session.ex:17 — yagni: save is stored and broadcast, but nothing reads it. Drop it and the create/2 :save option until the persistence work lands.

<verdict: 0 blocking, 1 should-fix, 0 nit, 1 ponytail · net: -3 lines possible>

Drop sessions/0; listing saved sessions belongs in a query module.

The stop reasons and log entries get types.

hhubert6 · 2026-10-22T15:23:16Z

@claude review

github-actions · 2026-10-22T15:23:32Z

Claude finished @hhubert6's task in 37s —— View job

🦀 Review

No findings: the #PID<0.X.Y> resolve is fixed, save was already raised, and nothing new in the struct and rename commits cleared the 60% bar.

GuzekAlan

Looks solid 🐙

…ctions

srzeszut

🐋

GuzekAlan

🐙

hhubert6 added this pull request to stack #306 October 15, 2026 13:11

github-actions Bot reviewed Oct 16, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer/config.ex Resolved

github-actions Bot reviewed Oct 16, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer/config.ex Resolved

github-actions Bot reviewed Oct 16, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer.ex Resolved

hhubert6 marked this pull request as ready for review October 16, 2026 13:35

hhubert6 requested review from GuzekAlan and srzeszut October 16, 2026 13:36

Base automatically changed from hubertkasprzycki/voy-325-agent-session-based-trace-api to main October 16, 2026 13:39

hhubert6 added 13 commits October 16, 2026 15:39

Add Tracer service owning the single tracing session

604f1e3

Supervise the Tracer service

e4f6cec

Stop the tracing session before disconnecting from the node

ddf27bb

Emit telemetry for trace session start, failure and stop

e20ebee

Test the Tracer service against the local agent

83f9055

Add validated tracing session config

3d8e233

Configure the tracing session separately from starting it

b9c2527

Compile the agent with the Tracer config's refusal lists

9db3037

Resolve traced pids on the node and stop tracing on disconnect withou…

b46642f

…t a remote call

Keep per-run Tracer state in the run and test mailbox drops

df2a33e

Return a field error for non-string traced pids

8c8bb65

Hash the agent's refusal lists into its module name

9b209ac

Name stop/0 in the Tracer moduledoc

e1dbf14

hhubert6 force-pushed the hubertkasprzycki/voy-327-tracer-service-single-session-manager-with-pubsub-status branch from 5b82607 to e1dbf14 Compare October 16, 2026 13:39

GuzekAlan reviewed Oct 20, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer.ex Resolved

Comment thread lib/voyager/services/tracer.ex Resolved

Comment thread lib/voyager/services/tracer.ex Resolved

GuzekAlan reviewed Oct 20, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer.ex Resolved

Comment thread lib/voyager/services/tracer.ex Resolved

kraleppa reviewed Oct 21, 2026

View reviewed changes

Broadcast dropped batches so the dropped count stays live

a483262

hhubert6 added 5 commits October 22, 2026 12:11

Log dropped events as entries instead of gaps in seq

dea7c0d

A batch that reports new drops, here or by the agent, and the run's end append a :dropped entry with the count before the events that follow. Dropped entries are capped with the trace events since a flood sheds a batch at a time.

Test the Tracer's start race and the drops reported at a run's end

74e6d4f

github-actions Bot reviewed Oct 22, 2026

View reviewed changes

Comment thread lib/voyager/pid.ex Resolved

github-actions Bot reviewed Oct 22, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer/session.ex Resolved

hhubert6 added 4 commits October 22, 2026 16:26

Rename the Tracer's buffer, run and count fields after what they hold

8038bb0

Drop sessions/0; listing saved sessions belongs in a query module.

Shrink

8bf9eeb

Type the Tracer's run and state as structs

310a814

The stop reasons and log entries get types.

Fix resolving pid

586d254

hhubert6 requested a review from GuzekAlan October 22, 2026 15:25

srzeszut reviewed Oct 23, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer.ex Resolved

GuzekAlan reviewed Oct 26, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer.ex Resolved

srzeszut reviewed Oct 26, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer/config.ex Resolved

GuzekAlan reviewed Oct 26, 2026

View reviewed changes

Comment thread lib/voyager/services/tracer.ex Resolved

Comment thread lib/voyager/services/tracer.ex Resolved

hhubert6 added 4 commits October 27, 2026 10:46

Return a field error for nil traced pids

e290124

Derive entries' truncated? from the page size instead of tracking evi…

6fa2428

…ctions

Validate the entries options in the caller

a529a54

Order entries by an explicit option instead of by whether since is given

5b0a982

hhubert6 force-pushed the hubertkasprzycki/voy-327-tracer-service-single-session-manager-with-pubsub-status branch from 702275b to 5b0a982 Compare October 27, 2026 09:46

hhubert6 requested review from GuzekAlan and srzeszut October 27, 2026 10:02

srzeszut approved these changes Oct 27, 2026

View reviewed changes

GuzekAlan approved these changes Oct 27, 2026

View reviewed changes

hhubert6 merged commit 9ab5d7c into main Oct 27, 2026
4 checks passed

Conversation

hhubert6 commented Oct 15, 2026

Uh oh!

hhubert6 commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦀 Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hhubert6 commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦀 Review

Uh oh!

GuzekAlan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kraleppa left a comment

Choose a reason for hiding this comment

Uh oh!

hhubert6 commented Oct 22, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦀 Review

Uh oh!

Uh oh!

Uh oh!

hhubert6 commented Oct 22, 2026

Uh oh!

github-actions Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦀 Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GuzekAlan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

srzeszut left a comment

Choose a reason for hiding this comment

Uh oh!

GuzekAlan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 22, 2026 •

edited

Loading

github-actions Bot commented Oct 22, 2026 •

edited

Loading