Skip to content

Share proc macro host - #3267

Open
wawel37 wants to merge 31 commits into
mainfrom
share-proc-macro-host
Open

Share proc macro host#3267
wawel37 wants to merge 31 commits into
mainfrom
share-proc-macro-host

Conversation

@wawel37

@wawel37 wawel37 commented Sep 21, 2026

Copy link
Copy Markdown
Member

No description provided.

@wawel37
wawel37 marked this pull request as ready for review September 29, 2026 13:53
@wawel37
wawel37 requested a review from a team as a code owner September 29, 2026 13:53
@wawel37
wawel37 requested review from Arcticae and integraledelebesgue and removed request for a team September 29, 2026 13:53
hakiers
hakiers requested changes Oct 8, 2026
View reviewed changes

@hakiers hakiers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase onto main?

Comment thread utils/scarb-proc-macro-server-types/Cargo.toml Resolved
hakiers
hakiers reviewed Oct 10, 2026
View reviewed changes

@hakiers hakiers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed partially

Comment thread scarb/src/ops/proc_macro_server/methods/expand_derive.rs Resolved
Comment thread scarb/src/ops/proc_macro_server/methods/expand_inline.rs Resolved
hakiers
hakiers reviewed Oct 12, 2026
View reviewed changes
Comment thread scarb/tests/proc_macro_v1_prebuilt.rs Resolved
hakiers
hakiers approved these changes Oct 12, 2026
View reviewed changes

@hakiers hakiers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Arcticae
Arcticae requested changes Oct 13, 2026
View reviewed changes
Comment thread utils/scarb-proc-macro-host/Cargo.toml Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/defined_macros.rs Resolved
Comment thread utils/scarb-proc-macro-host/src/backend.rs Resolved
Comment thread scarb/src/compiler/plugin/proc_macro/v2/backend.rs Resolved
Comment thread utils/scarb-proc-macro-host/src/backend.rs Resolved
Comment thread utils/scarb-proc-macro-host/src/host/derive/mod.rs Resolved
Comment thread utils/scarb-proc-macro-host/src/host/attribute/span_adapter.rs Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/expand.rs Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/expand.rs Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/mod.rs Resolved
@wawel37
wawel37 requested review from piotmag769 and a balanced review from Copilot and removed request for Copilot October 15, 2026 10:22
@wawel37
wawel37 requested a review from Arcticae October 15, 2026 14:09
piotmag769
piotmag769 reviewed Oct 20, 2026
View reviewed changes
Comment thread utils/scarb-proc-macro-server-types/src/methods/mod.rs Resolved
Comment thread scarb/src/ops/proc_macro_server/conversions.rs Resolved
Comment thread scarb/src/ops/proc_macro_server/conversions.rs Resolved
Comment thread scarb/src/compiler/plugin/collection.rs Resolved
Comment thread utils/scarb-proc-macro-host/src/host/derive/mod.rs Resolved
Comment thread MAINTAINING.md Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/mod.rs Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/mod.rs Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/mod.rs Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/mod.rs Resolved
@wawel37
wawel37 requested a review from piotmag769 October 21, 2026 14:45
piotmag769
piotmag769 approved these changes Oct 22, 2026
View reviewed changes

@piotmag769 piotmag769 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good logic wise - didn't review the new tests though

Comment thread scarb/src/ops/proc_macro_server/methods/expand_derive.rs Resolved
Comment thread scarb/src/ops/proc_macro_server/methods/expand_attribute.rs Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/mod.rs Resolved
Comment thread utils/scarb-proc-macro-server-types/src/methods/mod.rs Resolved
Comment thread MAINTAINING.md Resolved
Comment thread MAINTAINING.md Resolved
integraledelebesgue
integraledelebesgue reviewed Oct 22, 2026
View reviewed changes
Comment thread scarb/src/compiler/plugin/proc_macro/v1/ffi.rs Resolved
Comment thread scarb/src/compiler/plugin/proc_macro/v1/ffi.rs Resolved
Comment thread scarb/src/compiler/plugin/proc_macro/v2/ffi.rs Resolved
Comment thread scarb/src/compiler/plugin/proc_macro/v2/ffi.rs Resolved
piotmag769
piotmag769 approved these changes Oct 22, 2026
View reviewed changes

@piotmag769 piotmag769 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All g

Comment thread scarb/src/ops/proc_macro_server/methods/expand_attribute.rs Resolved
Comment thread scarb/src/ops/proc_macro_server/methods/expand_derive.rs Resolved
@wawel37

wawel37 commented Oct 22, 2026

Copy link
Copy Markdown
Member Author

Where is the comment?
@piotmag769

scarb/utils/scarb-proc-macro-server-types/src/methods/expand.rs

Lines 53 to 54 in 7f57e61

/// The response holds one result per derive, in this order.
pub derives: Vec<Derive>,

@integraledelebesgue integraledelebesgue mentioned this pull request Oct 26, 2026
Open
piotmag769
piotmag769 reviewed Oct 27, 2026
View reviewed changes
Comment thread utils/scarb-proc-macro-server-types/src/methods/defined_macros.rs Resolved
Comment thread scarb/src/ops/proc_macro_server/methods/expand_inline.rs Resolved
@wawel37
wawel37 requested a review from piotmag769 October 28, 2026 11:40
piotmag769
piotmag769 approved these changes Oct 28, 2026
View reviewed changes
Comment thread utils/scarb-proc-macro-host/src/host/attribute/inner_attribute.rs Resolved
Comment thread utils/scarb-proc-macro-host/src/host/attribute/span_adapter.rs Resolved
@wawel37
wawel37 requested a review from piotmag769 October 29, 2026 13:22

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakiers hakiers hakiers approved these changes
@Arcticae Arcticae Arcticae approved these changes
@piotmag769 piotmag769 piotmag769 approved these changes
@integraledelebesgue integraledelebesgue integraledelebesgue approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wawel37 @Arcticae @piotmag769 @integraledelebesgue @hakiers