Repository navigation
Strip trailing whitespace from packages/ios-client - #294
Merged
majkpal merged 1 commit intoAug 31, 2026
Merged
Conversation
`yarn lint:check` runs `swift-format lint -s`, where TrailingWhitespace is an error, and 26 lines across four files trip it. This is what the workspace's own `yarn lint` (`swift-format format -i`) produces, and the change is whitespace-only - `git diff -w` is empty. The failure is on main, so it currently fails the all_packages_lint job on every open pull request. `examples/ios` is unaffected because the ios_lint workflow runs the formatter before linting, so it fixes itself in the runner. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yarn lint:checkrunsswift-format lint -sfor theios-clientworkspace, and under-s(strict)TrailingWhitespaceis an error rather than a warning. 26 lines across four files trip it, so theall_packages_lintjob fails.This is on
main, not introduced by any open PR — it currently fails CI on every one of them. Reproduced on a cleanorigin/maincheckout: 26 errors, exactly the set CI reports.The fix is just the workspace's own
yarn lint(swift-format format -i) — no hand edits.Why this is safe
git diff -won the commit is empty: nothing but whitespace changed.swift-format lint -r -s ./Sources --configuration swift-format-config.jsonreports 0 errors.Why
examples/ioswas never affectedThe
ios_lintworkflow runsswift-format format -ibeforeswift-format lint, so it silently fixes the tree in the runner and then lints the fixed copy. Onlyall_packages_lint, which goes throughyarn lint:check, actually enforces this — and it only coverspackages/ios-client.Worth considering separately: having
ios_lintformat-then-lint means it can never fail on formatting, which is presumably not the intent.Merge order
Kept standalone and based directly on
mainso it can go in ahead of #291, #292 and #293 — all three go green once they pick it up. Happy to cherry-pick it into #291 instead if you would rather not have a fourth PR.🤖 Generated with Claude Code