Skip to content

fix: sanitizers weren't applied to the library itself - #1362

Merged
mdydek merged 2 commits into
mainfrom
test/sanitizers-tweaks
Oct 23, 2026
Merged

mdydek merged 2 commits into
mainfrom
test/sanitizers-tweaks

Conversation

@SomePersonFromMars

@SomePersonFromMars SomePersonFromMars commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

Sanitizers weren't applied to the library's translation units. Running tests with thread sanitizer enabled resulted in multiple false positives. It occured as though multiple tests failed with data races.

Also did some small tweaks to skills related to jsi and worklets.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@SomePersonFromMars SomePersonFromMars changed the title fix: Sanitizers weren't applied to the library itself fix: sanitizers weren't applied to the library itself Oct 22, 2026
@github-actions

Copy link
Copy Markdown

WPT non-regression comparison

PASS — no regressions · 0 improved section(s) · overall 3427 → 3427 (0)

Unchanged sections (28)
Spec section Base pass Head pass Delta
Processing model 1 1 0
Other 56 56 0
AnalyserNode 138 138 0
AudioBuffer 140 140 0
AudioBufferSourceNode 220 220 0
AudioContext 58 58 0
AudioNode 261 261 0
AudioParam 680 680 0
BiquadFilterNode 275 275 0
ChannelMergerNode 30 30 0
ChannelSplitterNode 7 7 0
ConstantSourceNode 64 64 0
ConvolverNode 178 178 0
DelayNode 127 127 0
DestinationNode 0 0 0
DynamicsCompressorNode 4 4 0
GainNode 15 15 0
IIRFilterNode 87 87 0
MediaElementAudioSourceNode 0 0 0
MediaStreamAudioDestinationNode 1 1 0
MediaStreamAudioSourceNode 0 0 0
OfflineAudioContext 35 35 0
OscillatorNode 104 104 0
PannerNode 727 727 0
PeriodicWave 33 33 0
ScriptProcessorNode 0 0 0
StereoPannerNode 104 104 0
WaveShaperNode 82 82 0

Baseline: 331cd7cc07cb7b92166a39e4f47514abbb4f7dd1 · Candidate: f98fb6b00e98c858a3688ca876934557a5cf7191

Workflow run · this comment is updated on every push.

@mdydek mdydek added the fix Code changes specifically addressing and resolving a bug label Oct 23, 2026
@mdydek
mdydek merged commit 644b0a5 into main Oct 23, 2026
14 checks passed
@mdydek
mdydek deleted the test/sanitizers-tweaks branch October 23, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Code changes specifically addressing and resolving a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants