Repository navigation
Conversation
mdydek
added this pull request to stack #1325
October 5, 2026 10:59
mdydek
added
fix
mdydek
force-pushed
the
fix/ios-voice-processing
branch
from
October 5, 2026 11:30
7cbda79 to
a9745cb
Compare
WPT non-regression comparisonPASS — no regressions · 0 improved section(s) · overall 3427 → 3427 (0) Unchanged sections (28)
Baseline: Workflow run · this comment is updated on every push. |
mdydek
force-pushed
the
fix/ios-voice-processing
branch
from
October 6, 2026 16:18
a9745cb to
fa7aa74
Compare
maciejmakowski2003
requested changes
Oct 8, 2026
|
|
||
| [self rebuildAudioEngineAndResumeIfNeeded]; | ||
| if (![self rebuildAudioEngineAndResumeIfNeeded]) { | ||
| self.state = AudioEngineState::AudioEngineStatePaused; |
Collaborator
There was a problem hiding this comment.
Suggested change
| self.state = AudioEngineState::AudioEngineStatePaused; | |
| self.state = AudioEngineState::AudioEngineStateIdle; |
| return; | ||
| } | ||
|
|
||
| if (![self hasInputConnectionFormatChanged]) { |
Collaborator
There was a problem hiding this comment.
are you sure that it is only condition? what if receorder was left without a sink by a failed rebuild?
| self.state = AudioEngineState::AudioEngineStateIdle; | ||
| [self notifyConfigurationChanges]; | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
shouldnt we notify outpus if shouldResume is true as well?
|
|
||
| [self rebuildAudioEngine]; | ||
| if (![self rebuildAudioEngine]) { | ||
| _isRebuildingAudioEngine = NO; |
Collaborator
There was a problem hiding this comment.
same path as in onInterruptionEnd so shouldnt we call both notify methods?
mdydek
force-pushed
the
fix/ios-voice-processing
branch
from
October 9, 2026 07:39
fa7aa74 to
7087acb
Compare
github-actions
Bot
added
the
conflicts
3 tasks done
Member
Author
|
the better rework, which would contain this fix will be done in #1317 |
An error occurred while trying to automatically change base from
feat/android-communication-session
to
main
October 20, 2026 13:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct continuation of the work in #1316
Introduced changes
Checklist