Repository navigation
Conversation
Update the Kotlin and Coroutines toolchain and test native marker encoding. Drop iosX64, which is unsupported by the new toolchain, and fail framework builds on partial linkage.
|
We would love for this PR to land soon. For now, we have to fork and publish locally in our CI flow to get kmp-maps working. This is currently a blocker for us as well, so getting this merged and released would save us from maintaining our own fork. Thanks for the work on this! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Custom markers can crash on iOS when an application consumes the published core 0.9.1 library with Compose Multiplatform 1.12.0:
The failing path is
ImageBitmap.toUIImage()inExtensions.kt. The older precompiled Kotlin/Native library references the previous Skia signature. Recompiling the existing source against Compose 1.12 resolves that call without changing marker behavior.Changes
SubclassOptInRequiredconstructor.iosX64target and obsolete native-cache properties.Validation
encodeToDataerror with a separate iOS simulator test consuming the published 0.9.1 binary and Compose 1.12.0.:kmp-maps:core:linkDebugFrameworkIosSimulatorArm64with strict partial linkage.:kmp-maps:core:compileDebugKotlinAndroid.:kmp-maps:core:linkReleaseFrameworkIosArm64with strict partial linkage.:kmp-maps:core:compileKotlinJvm,:kmp-maps:google-maps:compileDebugKotlinAndroid, and:kmp-maps:google-maps:compileKotlinJvm.This requires a new library publication before downstream applications can consume the rebuilt binaries.