Repository navigation
Conversation
…ker tap MarkerComposable and onClusterItemClick both returned `onMarkerClick == null` from their onClick lambdas. In maps-compose, returning false means the click is not consumed and the default info window is shown. Since `onMarkerClick == null` evaluates to false whenever a handler is set, the info window always appeared when using customMarkerContent — the opposite of the intended behavior. Return true unconditionally in both the MarkerComposable and clustering paths so the click is consumed and the native info window is suppressed. Custom marker content owns the full visual representation and has no use for the native overlay. The standard Marker path (no custom content) is unchanged. Fixes software-mansion#174
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ker tap
MarkerComposable and onClusterItemClick both returned
onMarkerClick == nullfrom their onClick lambdas. In maps-compose, returning false means the click is not consumed and the default info window is shown. SinceonMarkerClick == nullevaluates to false whenever a handler is set, the info window always appeared when using customMarkerContent — the opposite of the intended behavior.Return true unconditionally in both the MarkerComposable and clustering paths so the click is consumed and the native info window is suppressed. Custom marker content owns the full visual representation and has no use for the native overlay. The standard Marker path (no custom content) is unchanged.
Fixes #174