Merge pull request repejota#54 from dfeyer/task-remove-openssl

BUGFIX: Don't use openssl_random_pseudo_bytes as it break the protocol

Author: repejota

composer.json

@@ -5,6 +5,7 @@
     "minimum-stability": "dev",
     "license": "MIT",
     "require": {
+        "ircmaxell/random-lib": "^1.1"
     },
     "require-dev": {
         "phpunit/phpunit": "4.7.*",

src/Connection.php

@@ -1,6 +1,9 @@
 <?php
 namespace Nats;
 
+use RandomLib\Factory;
+use RandomLib\Generator;
+
 /**
  * Connection Class.
  */
@@ -112,6 +115,11 @@ public function getSubscriptions()
      */
     private $streamWrapper;
 
+    /**
+     * @var Generator
+     */
+    private $randomGenerator;
+
     /**
      * Constructor.
      *
@@ -124,6 +132,8 @@ public function __construct(ConnectionOptions $options = null)
         $this->subscriptions = [];
         $this->options = $options;
         $this->streamWrapper = new StreamWrapper();
+        $randomFactory = new Factory();
+        $this->randomGenerator = $randomFactory->getLowStrengthGenerator();
 
         if (is_null($options)) {
             $this->options = new ConnectionOptions();
@@ -296,7 +306,7 @@ public function publish($subject, $payload = null)
      */
     public function subscribe($subject, \Closure $callback)
     {
-        $sid = uniqid();
+        $sid = $this->randomGenerator->generateString(16);
         $msg = 'SUB '.$subject.' '.$sid;
         $this->send($msg);
         $this->subscriptions[$sid] = $callback;
@@ -315,7 +325,7 @@ public function subscribe($subject, \Closure $callback)
      */
     public function queueSubscribe($subject, $queue, \Closure $callback)
     {
-        $sid = openssl_random_pseudo_bytes(16);
+        $sid = $this->randomGenerator->generateString(16);
         $msg = 'SUB '.$subject.' '.$queue.' '. $sid;
         $this->send($msg);
         $this->subscriptions[$sid] = $callback;