TASK: Use random string generator in Connection::subscribe method

dfeyer · dfeyer · commit 87d762bb7d7c · 2016-05-27T18:47:36.000+02:00
diff --git a/src/Connection.php b/src/Connection.php
@@ -306,7 +306,7 @@ public function publish($subject, $payload = null)
      */
     public function subscribe($subject, \Closure $callback)
     {
-        $sid = uniqid();
+        $sid = $this->randomGenerator->generateString(16);
         $msg = 'SUB '.$subject.' '.$sid;
         $this->send($msg);
         $this->subscriptions[$sid] = $callback;

Original file line number	Diff line number	Diff line change
`@@ -306,7 +306,7 @@ public function publish($subject, $payload = null)`
`306`	`306`	`*/`
`307`	`307`	`public function subscribe($subject, \Closure $callback)`
`308`	`308`	`{`
`309`		`- $sid = uniqid();`
	`309`	`+ $sid = $this->randomGenerator->generateString(16);`
`310`	`310`	`$msg = 'SUB '.$subject.' '.$sid;`
`311`	`311`	`$this->send($msg);`
`312`	`312`	`$this->subscriptions[$sid] = $callback;`