Skip to content

[LinearSystem] Fix CompositeLinearSystem not invalidating its matrix #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 5 commits into from
Aug 4, 2026
+7 −3
Merged

[LinearSystem] Fix CompositeLinearSystem not invalidating its matrix #6202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
891482b
[fix] Link d_matrixChange Data
alxbilger Jul 24, 2026
286ae59
remove duplicated visual manager loop
alxbilger Jul 24, 2026
6eb2d82
add regression
alxbilger Jul 24, 2026
da74587
remove problematic plugin
alxbilger Jul 28, 2026
52300f6
Apply suggestions from code review
fredroy Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Sofa/Component/LinearSystem/src/sofa/component/linearsystem/CompositeLinearSystem.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ void CompositeLinearSystem<TMatrix, TVector>::init()
}
}
}

if (!this->isComponentStateInvalid())
{
this->d_matrixChanged.setParent(&l_solverLinearSystem->d_matrixChanged);
}
}

template <class TMatrix, class TVector>
Expand Down
4 changes: 1 addition & 3 deletions examples/Component/LinearSystem/CompositeLinearSystem.scn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@
<RequiredPlugin pluginName="Sofa.Component.Topology.Container.Grid"/> <!-- Needed to use components [RegularGridTopology] -->
<RequiredPlugin pluginName="Sofa.Component.Visual"/> <!-- Needed to use components [VisualStyle] -->
<RequiredPlugin pluginName="Sofa.GL.Component.Rendering3D"/> <!-- Needed to use components [OglModel] -->
<RequiredPlugin pluginName="SofaMatrix.Qt"/> <!-- Needed to use components [GlobalSystemMatrixImage] -->
<RequiredPlugin pluginName="SofaMatrix"/> <!-- Needed to use components [GlobalSystemMatrixImage] -->

<VisualStyle displayFlags="showBehaviorModels showWireframe" />

<DefaultAnimationLoop/>
<DefaultVisualManagerLoop/>

<DefaultVisualManagerLoop/>

<Node name="node">
<EulerImplicitSolver name="odesolver" rayleighStiffness="0.1" rayleighMass="0.1" />

Expand Down
1 change: 1 addition & 0 deletions examples/RegressionStateScenes.regression-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Component/LinearSolver/Preconditioner/FEMBAR_PCG_NoPreconditioner.scn 100 1e-8 0
Component/LinearSolver/Preconditioner/FEMBAR_PCG_PrecomputedWarpPreconditioner.scn 100 1e-8 0 1
Component/LinearSolver/Preconditioner/FEMBAR_PCG_SSORPreconditioner.scn 100 1e-8 0 1
Component/LinearSolver/Preconditioner/FEMBAR_PCG_WarpPreconditioner.scn 100 1e-8 0 1
Component/LinearSystem/CompositeLinearSystem.scn 100 1e-8 0 1
Component/Mapping/NonLinear/DistanceMapping.scn 100 1e-8 0 1
Component/Mapping/NonLinear/DistanceMultiMapping.scn 100 1e-8 0 1
Component/Mapping/NonLinear/SquareDistanceMapping.scn 100 1e-8 0 1
Expand Down
Loading