[CORE] Refactoring add functions from BaseLink and Link - #6129
Open
Lucas-TJ wants to merge 28 commits into
Open
Conversation
fredroy
added
pr: status to review
Contributor
|
[ci-build][with-all-tests] |
bakpaul
added
pr: status wip
alxbilger
reviewed
Jun 18, 2026
| : Inherit(init), m_validator(nullptr) | ||
| { | ||
| if (val) this->add(val); | ||
| if (val) this->_doAdd_(sofa::core::castToBase(TraitsDestPtr::get(val))); |
Contributor
There was a problem hiding this comment.
I am a bit confused about this change. Could you explain?
alxbilger
added
pr: status to review
bakpaul
added
pr: status wip
bakpaul
approved these changes
Jul 16, 2026
Contributor
|
[ci-build][with-all-tests] |
Contributor
|
@Lucas-TJ can you solve the conflicts? |
* [v26.06] Add changelog (sofa-framework#6180) Add changelog for v26.06 * Bump version to v26.12.99 * forgotten build action --------- Co-authored-by: Paul Baksic <30337881+bakpaul@users.noreply.github.com>
…in for topology (sofa-framework#6212) fix required plugin for TetrahedronHyperelasticityFEMForceField
* add doremove * clean * add unit test * remove useless include
* Fix unit test for forcefeedback * Fix forces values
sofa-framework#6175) * rename to VolumeFromVolumetricElements * compat * last changes * rename test file * rename example * add to component change list * add alias
* add doremove * clean * add unit test * remove useless include
* add doremove * clean * add unit test * remove useless include
Lucas-TJ
added
pr: status wip
alxbilger
reviewed
Jul 31, 2026
| return TLink::addDestPtrPath(destptr, path); | ||
| } | ||
|
|
||
| bool _doAdd_(Base* baseptr) override |
Contributor
There was a problem hiding this comment.
Make sure that this method has the same visibility than the base class (it should stay protected)
Contributor
Author
There was a problem hiding this comment.
Yes, _doAdd_ function is protected like the base class.
Lucas-TJ
added
the
topic for next dev-meeting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is there to make the code of the add functions clearer in BaseLink and Link.
Later, I will add some unit tests.
Thank you
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if