Skip to content

[SofaMatrix] Allow newer metis versions - #5698

Closed
LunNova wants to merge 1 commit into
sofa-framework:masterfrom
LunNova:master
Closed

[SofaMatrix] Allow newer metis versions#5698
LunNova wants to merge 1 commit into
sofa-framework:masterfrom
LunNova:master

Conversation

@LunNova

@LunNova LunNova commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Fixes #5697


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy

fredroy commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

The requirement of having an exact version for metis was made on purpose apparently, according to @alxbilger #4450 (comment)

@LunNova

LunNova commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

Can it be relaxed to allow >=5.2.1 or 5.1.0 exactly then? Sounds like there was a faulty in between version that must be avoided.

5.1.0 is from 2013 and incompatible with CMake 4.

@alxbilger

Copy link
Copy Markdown
Contributor

I think at the time we forced the exact version, the version 5.2.1 was not available on conda. That is why we forced version 5.1.0. Based on conda-forge/metis-feedstock#43, it seems it is now available (@olivier-roussel do you confirm?). In that case, it worth trying to apply your suggestion (>=5.2.1 or 5.1.0 exactly). You can try and see if the CI is happy.

@LunNova
LunNova force-pushed the master branch 2 times, most recently from 0375445 to 34dae4e Compare September 19, 2025 17:22
@LunNova

LunNova commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

ubuntu check failure was g++: fatal error: Killed signal terminated program cc1plus. I'd hope that's not related to this, did that box OOM?

@LunNova
LunNova force-pushed the master branch 2 times, most recently from e0b9cf9 to 2bb07a4 Compare September 20, 2025 16:05
Fixes sofa-framework#5697

metis 5.1.0 is known to work, versions newer than 5.1 and older than
5.2.1 are broken. A fix was applied in a commit[1] that was first
included in 5.2.1.

[1]: KarypisLab/METIS@36262ad
@fredroy fredroy added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 21, 2025
@fredroy

fredroy commented Sep 21, 2025

Copy link
Copy Markdown
Contributor

[ci-build][with-all-tests]

@olivier-roussel

Copy link
Copy Markdown
Contributor

Yes, we fixed metis 5.1.0 initially as the latest release at this time 5.1.1 was apparently broken ( KarypisLab/METIS#69, conda-forge/metis-feedstock#35 ).
With the release 5.2.1 which is available also on conda-forge, if CI passes we should move to it.

@alxbilger

Copy link
Copy Markdown
Contributor

@LunNova The compilation issue on Ubuntu is not due to your changes.

@alxbilger

Copy link
Copy Markdown
Contributor

Note that if this PR is accepted, it will also make sense to apply it on https://github.com/sofa-framework/Sofa.Metis/blob/master/CMakeLists.txt

@alxbilger

Copy link
Copy Markdown
Contributor

@bakpaul Do you see a way to run the CI with Metis 5.2.1?

@olivier-roussel

Copy link
Copy Markdown
Contributor

To be more precise, we do not use so far metis conda package as we do not provide a conda package for Sofa.Metis plugin. The conda package use was at the time where Sofa.Metis was still part of SOFA. And from what I remember we were using a specific version of metis compiled with some extra options, which are typically not available from current conda binaries yet. We can still dig about that if at some point we want of conda package for Sofa.Metis, maybe this can be achieved by pushing for a binary variant of the package with these options, if that make sense for the community.
This remark does not apply with Pixi build chain which fetches metis.

@bakpaul

bakpaul commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

@alxbilger I just need to fetch the branch on our METIS fork, rework the packaging again and we can try it with a simple ci-depends-on, but not on this PR, I'll open a drafted one to test it so we can merge this asap.

@bakpaul

bakpaul commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

Well actually it seems like we have already tried this version, and I don't remember if we dropped it because of Conda constraints or if it was because it was messing with the unit tests. Let's see : #5703

@fredroy

fredroy commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Closing, #5732 has been merged and is based on this one

@fredroy fredroy closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SofaMatrix should allow non-EXACT metis versions

5 participants