SNOW-2912540: decouple LocalTestOOBTelemetryService from connector.telemetry_oob - #4309
Open
sfc-gh-fpawlowski wants to merge 3 commits into
Open
Conversation
…lemetry_oob The UD's telemetry_oob.TelemetryService is a no-op stub (BD#45) that lacks batch_size, causing an AttributeError at runtime. Make LocalTestOOBTelemetryService standalone: add its own singleton, queue, batch_size, _enabled, and close(). Also fixes the pre-existing _enable typo (should have been _enabled). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Aug 6, 2026
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Aug 6, 2026
3 tasks
sfc-gh-fpawlowski
marked this pull request as ready for review
August 17, 2026 18:00
sfc-gh-fpawlowski
requested review from
sfc-gh-jzeng,
sfc-gh-mayliu and
sfc-gh-yuwang
and removed request for
a team
August 17, 2026 18:00
…912540-decouple-oob-telemetry
…ng-helpers' into HEAD
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## SNOW-2912540-inline-pandas-staging-helpers #4309 +/- ##
===========================================================================
Coverage 80.99% 80.99%
===========================================================================
Files 170 170
Lines 44663 44663
Branches 7677 7677
===========================================================================
Hits 36174 36174
Misses 6969 6969
Partials 1520 1520 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UD's
telemetry_oob.TelemetryServiceis a no-op stub (BD#45) that is missingbatch_size, whichLocalTestOOBTelemetryService.add()uses — causing anAttributeErrorat runtime.Makes
LocalTestOOBTelemetryServicefully standalone by:from snowflake.connector.telemetry_oob import TelemetryServiceand the inheritanceget_instance())self.queue,self.batch_size, andself._enableddirectly in__init__close()(delegates toflush(), called byatexit)self._enabletypo (should have been_enabled)SecretDetector(also from the connector) is still present — it exists in the UD and is not being decoupled here.Checklist
Stack (via Graphite)
🤖 Generated with Claude Code