fix(ci): add pagination to check-cuda-versions GitLab API calls - #5
Closed
smoparth wants to merge 1 commit into
Closed
fix(ci): add pagination to check-cuda-versions GitLab API calls#5smoparth wants to merge 1 commit into
smoparth wants to merge 1 commit into
Conversation
The check-cuda-versions workflow fetched CUDA versions from NVIDIA's GitLab API with per_page=100 but made only a single API call with no pagination handling. If NVIDIA's dist/ directory exceeds 100 entries, results would be silently truncated. Add a fetch_all_pages() function that loops through pages, accumulates JSON arrays with jq, and includes a safety limit of 10 pages (1000 items max) to prevent infinite loops. Fixes opendatahub-io#28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check-cuda-versionsworkflow's GitLab API callsfetch_all_pages()function that loops through pages until exhausted::warning::annotation if reachedDetails
The workflow previously made a single
curlcall withper_page=100. While NVIDIA currently has only ~19 entries in theirdist/directory, this would silently truncate results if the count exceeded 100.The new
fetch_all_pages()function:pageparameterjq -s 'add'per_pageitemsBoth the primary (URL-encoded path) and fallback (numeric ID) API calls use the same function.
Test plan
fetch_all_pages()against live NVIDIA GitLab API — returns all 19 items[], enabling fallbackFixes opendatahub-io#28
🤖 Generated with Claude Code