Repository navigation
⬆️ native: pin 11.2.2 on both platforms so the liveness fix reaches React Native apps - #246
Conversation
…eact Native apps Picks up the SmartSelfie™ fix where a job could carry the same liveness picture twice, plus the rotated request-signing secret and active_liveness_version 2.1.0. The wrapper's own version goes to 11.2.2 as well. Android reads package.json for setWrapperInfo, so only the hardcoded literal in ios/RNSmileID.swift needed moving alongside it. Podfile.lock is left alone: refreshing it needs a pod install against the published SmileID pod, which is not on trunk yet.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
🔍 Semgrep Security Scan Results✅ No security findings detected by |
PR Code Suggestions ✨No code suggestions found for the PR. |
pod install refuses to cross a lockfile pin: the lock held SmileID (= 11.2.1) while the podspec now requires (= 11.2.2), so CI failed with 'could not find compatible versions for pod SmileID' and the hint to run pod update. Ran `pod update SmileID SmileIDSDK`, which is surgical — no other pod moved. The dev pod's own checksum changes too, since react-native-smile-id's version went to 11.2.2 with package.json. Left out of this commit: pod install also reorders SmileIdExample/PrivacyInfo.xcprivacy, which has nothing to do with the version bump.
User description
Story: https://app.shortcut.com/smileid/story/xxx
Summary
Pins the native SDKs to 11.2.2 on both platforms, so React Native apps pick up the
SmartSelfie™ fix where a job could carry the same liveness picture twice.
android/gradle.propertiesandreact-native-smile-id.podspectake the new native versions.package.json. Android reads that file forsetWrapperInfoso it needs no edit, butios/RNSmileID.swifthardcodes the same value anddoes — it reports the wrapper version, not the native one, so it drifts silently if missed.
11.2.2 also carries a rotated request-signing secret and raises
active_liveness_versionto 2.1.0, neither of which needs anything from this wrapper.Known Issues
Do not merge until the iOS release finishes publishing. Android 11.2.2 is live on Maven
Central, but the iOS side is mid-flight: the
SmileIDpod is the last artifact in that chainand is not on CocoaPods trunk yet. Until it is,
pod installcannot resolveSmileID 11.2.2,so CI here will fail on the iOS job — that failure is expected and is not a problem with this
diff.
Podfile.lockin the sample app(s) is deliberately not updated. Regenerating it needs apod installagainst the published pod, which cannot run yet for the reason above. Theprevious native bump updated those lockfiles in the same change, so they should be refreshed
before this merges rather than left stale.
Not verified on a device, and not verified against a real build: the native dependency it
points at is not fully published yet.
Test Instructions
Once
pod trunk info SmileIDlists 11.2.2, runpod installin the sample app to refreshPodfile.lock, then build and run the sample on both platforms. The versions to expect:com.smileidentity:android-sdk:11.2.2SmileID11.2.2setWrapperInfo: 11.2.2Screenshot
N/A — no UI changes.
⬆️
PR Type
Enhancement, Documentation
Description
Pin Android and iOS native SDKs to 11.2.2
Bump wrapper version to 11.2.2
Update hardcoded iOS
setWrapperInfoversionAdd CHANGELOG entry for the bump
Diagram Walkthrough
File Walkthrough
gradle.properties
Bump Android native SDK pin to 11.2.2android/gradle.properties
SmileId_androidVersionfrom 11.2.1 to 11.2.2react-native-smile-id.podspec
Bump iOS SmileID pod pin to 11.2.2react-native-smile-id.podspec
SmileIDpod dependency to 11.2.2RNSmileID.swift
Update hardcoded iOS wrapper version stringios/RNSmileID.swift
SmileID.setWrapperInfoto 11.2.2
package.json
Bump wrapper package version to 11.2.2package.json
setWrapperInfoCHANGELOG.md
Add 11.2.2 changelog entryCHANGELOG.md
with release links