Repository navigation
Start the outcome window at the decision with a 60-minute lock - #66
Merged
Merged
Conversation
Every randomized decision point, sent or not, opens an outcome window anchored on decision_made_at (protocol 9.2), so the proximal outcome is timed identically in both arms for the excursion-effect estimate. /ema/next/ serves only the C0 rating for the first OUTCOME_CHECK_IN_DELAY_MINUTES (60, provisional), then the outcome check-in until +2 h; one reminder goes out if it is unanswered at +60. Drops the visible check-in push sent to the randomized-out arm at the decision (68e507b), which would now open an empty /ema/next/. Migrations 0050_checkinreminder_outcome_window and 0052 merge are byte-identical to analytics-views so the branches merge without a migration conflict. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tylerrleee
requested review from
Geaboi,
shawnwyb and
tylerlocnguyen
and removed request for
Geaboi and
shawnwyb
October 5, 2026 15:24
Contributor
|
Exactly what the paper wanted. Good job Tyler. LGTM! |
Geaboi
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Every randomized decision point, sent ($D = 1$ ) or not ($D = 0$ ), opens an outcome window anchored on decision_made_at (protocol 9.2), so the proximal outcome is timed identically in both arms (sent, or no sent) for the excursion-effect estimate.
Previous PR and commit 68e507b would send check-in right at the decision point, at time t--where each 1 unit of t is 1 minute. However, outcome window should be open at t = [60, 120].
TLDR
/ema/next/ serves only the C0 rating for the first OUTCOME_CHECK_IN_DELAY_MINUTES (60, provisional), then the outcome check-in until +2 h; one reminder goes out if it is unanswered at +60.
Outcome check-in no longer depends on push_sent_at, but rather after a locked window from t = [0,60)
Drops the visible check-in push sent to the randomized-out arm at the decision, which would now open an empty /ema/next/. Migrations 0050_checkinreminder_outcome_window and 0052 merge are byte-identical to analytics-views so the branches merge without a migration conflict.