Update index.js#1
Open
seyoon20087 wants to merge 2 commits into
Open
Conversation
please see the comments in index.js for more information. Signed-off-by: seyoon20087 <24852454+seyoon20087@users.noreply.github.com>
3 tasks
seyoon20087
marked this pull request as ready for review
July 23, 2026 11:39
slorber
requested changes
Jul 23, 2026
slorber
left a comment
slorber
left a comment
Owner
There was a problem hiding this comment.
See my suggestion here facebook/docusaurus#12311 (comment)
Signed-off-by: seyoon20087 <24852454+seyoon20087@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: i have not put
this._loadModule()directly in the constructor.While running the test (jest), I found that putting
this._loadModule()in the constructor led to undefined behavior, causing almost all tests to fail (which may also affect runtime behavior).So, I moved only the reporting feature from
this._loadModule()in the constructor, but I put the remaining stuff fromthis._loadModule()tocomponentDidMount.