fix: expand Windows-style home-relative export paths - #207
Merged
Conversation
Treat ~ followed by / or \ as homedir-relative so export.path values like ~\exports\quota.json resolve correctly on Windows. Fixes slkiser#206
LHMQ878
force-pushed
the
fix/206-export-path-windows-tilde
branch
from
August 8, 2026 09:19
85063da to
f816446
Compare
Split Windows-style home-relative suffixes before native path joining so Linux and Windows resolve them consistently.\n\nPreserve bare tilde and unrelated backslash paths to avoid widening export path expansion semantics.
Owner
|
@LHMQ878 Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~followed by/or\as home-relative inresolveExportPath~tohomedir()Test plan
pnpm exec vitest run tests/lib.quota-export.test.ts(new Windows tilde case passes)Fixes #206