Use swift-log as logging system - #34
Conversation
|
@filipbodor could you please link this PR with #24 issue to make it trackable and update the status (and other details, like "assignee") of that issue? We use this approach for all other features in this library, since we don't use Jira for open-source projects. |
038d087 to
ec6371d
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec6371db96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| do { | ||
| let post = try deviceAuthorizationRequest(params: params).asURLRequest(for: self) | ||
| logger?.debug("OAuth2", msg: "Obtaining device code from \(post.url!)") | ||
| logger?.debug("Obtaining device code from \(post.url!)") |
There was a problem hiding this comment.
We should remove the force unwrapping code of the post.url! in a future PR as it is a potential crash site.
dd38732 to
6aed1ab
Compare
3 participants
As we now use swift-log in slido for mac project, it makes sense to transfer to the logging system also in this swift library.
Removed:
I removed old logging system which was used by this library.
Implemented:
Instead of storing OAuth2Logger instance, the library will store Logger instance from swift-log framework.
I needed to change the way log messages were written: