This repository was archived by the owner on Aug 10, 2026. It is now read-only.
fix: constrain skill links to packaged tree (#15) - #18
Merged
Conversation
validate_links() now resolves local Markdown targets canonically and requires every resolved target to remain inside design-workflow/. Links that escape via .., absolute paths, symlink resolution, or equivalent traversal are rejected before filesystem existence is checked. External URLs, mailto links, and other non-file URI schemes continue to be skipped. Fragment-only links and links with fragments remain valid when their file target is inside the skill tree. Regression tests cover the reported escape cases, valid internal links, and existing committed skill documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #15