This repository was archived by the owner on Aug 10, 2026. It is now read-only.
fix: harden route-case boolean validation (#14) - #17
Merged
Conversation
Issue #14: mutates_artifact and redesign_authorized were treated as runtime truthy checks without strict boolean type validation. Mutating routes (preserve, expand, create, redesign, translate) were also not required to declare mutates_artifact: true. validated_contract: - mutates_artifact must be a real bool for every route case - redesign_authorized must be a real bool for every route case - preserve/expand/create/redesign/translate require mutates_artifact: true - critique/brand-check/profile require mutates_artifact: false - redesign still requires redesign_authorized: true (unchanged) - errors identify the case id plus the offending field or route contract Add regression coverage for string/integer rejections, each mutating route rejecting mutates_artifact: false, each non-mutating route rejecting mutates_artifact: true, and committed-fixture pass-through. Red+green: full suite moves from 31 to 39 tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #14