Ensure templated closures' return types factor into type resolution - #189
Open
mszabo-wikia wants to merge 1 commit into
Open
Ensure templated closures' return types factor into type resolution#189mszabo-wikia wants to merge 1 commit into
mszabo-wikia wants to merge 1 commit into
Conversation
Currently type resolution for templated closures where a template type
is shared by the closure's return type and a different parameter,
e.g. `reduce<Tv, Ta>(Traversable<Tv>, (function(Ta, Tv): Ta), Ta $initial): Ta`
is narrowed down only to the type of the parameter.
This is incorrect if the closure may produce a wider range of return types, e.g.:
```hack
function test(vec<int> $items): Base {
return reduce(
$items,
($accum, $item) ==> {
if ($item > 0) {
return new NoGet(); // accumulator can become NoGet...
}
return new HasGet($accum->get()); // ...so $accum is not provably HasGet
},
new HasGet("init"),
);
}
```
So do a second closure analysis if the inferred param type widens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently type resolution for templated closures where a template type is shared by the closure's return type and a different parameter, e.g.
reduce<Tv, Ta>(Traversable<Tv>, (function(Ta, Tv): Ta), Ta $initial): Tais narrowed down only to the type of the parameter. This is incorrect if the closure may produce a wider range of return types, e.g.:So do a second closure analysis if the inferred param type widens.