Fix empty provider api keys - #144
Open
rayan-sharma-git wants to merge 2 commits into
Open
rayan-sharma-git wants to merge 2 commits into
rayan-sharma-git wants to merge 2 commits into
Conversation
Changed the API key check from: if self.api_key is not None: to: if self.api_key: The previous check considered an empty API key as valid because an empty string is not None. The new check only considers the provider available when an actual API key is provided.
Changed the API key check from: if self.api_key is not None: to: if self.api_key: The previous check treated an empty API key as valid. The new check only considers the OpenAI provider available when an API key is actually provided.
|
Thanks for the contribution! Before we can merge this, we need @rayan-sharma-git to sign the Salesforce Inc. Contributor License Agreement. |
Author
|
Hi, I have already signed the Salesforce CLA using my GitHub account, and I have also added and verified the email address used for the CLA in my GitHub account. However, the CLA check on this PR is still showing as missing. Could someone please re-check/re-run the CLA verification for this PR? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
The OpenAI and Anthropic providers treated an empty API key as valid because they checked whether the value was not None.
Changed:
if self.api_key is not None:
to:
if self.api_key:
This ensures the providers are only considered available when an API key is actually provided.
is not None treats an empty string ('') as valid because '' is still a value and is not None, while if self.api_key checks whether the value actually contains something.
For example:
self.api_key = ''
Then:
if self.api_key is not None: # True
if self.api_key: # False
Fixes #57
Requirements