Fix Network Observer Chart Hook Deletion Policy

[c-kruse]

Changes the deletion policy on network-observer Chart's pre-install hook resources. Adds before-hook-creation so that Helm will delete resources from previous failed install attempts instead of erroring out.

Closes #2500

Summary by CodeRabbit

• Chores
  • Modified Helm hook cleanup behavior for setup operations to adjust the timing of resource deletion during deployment cycles.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ed367a3c-53b9-4fc7-b646-c710b40d1c82

📥 Commits

Reviewing files that changed from the base of the PR and between 429fcf4 and f046cdf.

📒 Files selected for processing (1)

• charts/network-observer/templates/job_setup_secrets.yaml

---

📝 Walkthrough

Walkthrough

The helm.sh/hook-delete-policy annotation on the four pre-install hook resources (Job, ServiceAccount, Role, RoleBinding) in job_setup_secrets.yaml is changed from hook-succeeded to before-hook-creation,hook-succeeded.

Changes

Hook Delete Policy Update

Layer / File(s)	Summary
hook-delete-policy annotation on all four resources charts/network-observer/templates/job_setup_secrets.yaml	helm.sh/hook-delete-policy changed from hook-succeeded to before-hook-creation,hook-succeeded on the Job (line 15), ServiceAccount (line 58), Role (line 71), and RoleBinding (line 93).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: updating the Helm hook deletion policy to fix an issue with orphaned resources after failed installations.
Linked Issues check	✅ Passed	The PR implements the exact solution specified in issue #2500: updating helm.sh/hook-delete-policy from hook-succeeded to before-hook-creation,hook-succeeded across all pre-install hook resources.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the hook deletion policy issue described in #2500; no unrelated or out-of-scope modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[JPadovano1483]

lgtm